Change running without normal compilation to a property #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration could be made only when the mode is enabled
maiflai
reviewed
Aug 22, 2021
|
|
||
| ### Compatibility with Consistent Versions Plugin | ||
|
|
||
| In order for the plugin to work alongside [Palantir's consistent versions plugin](https://github.com/palantir/gradle-consistent-versions), | ||
| the Scala version must be manually configured (via `scoverageScalaVersion`); otherwise, the plugin will attempt to | ||
| resolve the compilation classpath, which is prohibited by the versions plugin. | ||
|
|
||
| Migration to 6.1.1 |
There was a problem hiding this comment.
I think this is what would normally be considered a breaking change - should we be releasing 7.0.0 here?
I'm sure there is a better way of managing updates to the README, but for now could we remove this file from the PR?
There was a problem hiding this comment.
@maiflai I was counting on you to make the right decision on whether this should bump the major version or not :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153, #150.
This PR changes the way that running without normal compilation is enabled, from
-x compileScalato-PscoverageCompileOnly.This allows the plugin to detect that this option is selected earlier in the configuration stage, so then it can perform certain actions -- such as depending on dependent projects' scoverage compile tasks -- only if the option is enabled.
This should resolve #153 and also provide a partial solution to #150, so now parallel mode will work with normal compilation and will only fail to work without normal compilation (in multi-module projects).