Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API Span::take_ident which replaces primitives::ident #103

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

scouten
Copy link
Owner

@scouten scouten commented Jul 29, 2024

No description provided.

@scouten scouten self-assigned this Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (5c4b3df) to head (9cd048b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   99.16%   98.34%   -0.83%     
==========================================
  Files          23       23              
  Lines         961      965       +4     
==========================================
- Hits          953      949       -4     
- Misses          8       16       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jul 29, 2024

CodSpeed Performance Report

Merging #103 will improve performances by 17.31%

Comparing span+take_ident (9cd048b) with main (5c4b3df)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark main span+take_ident Change
inline_macro 21.1 µs 18 µs +17.31%

@scouten scouten merged commit 3200662 into main Jul 29, 2024
19 of 20 checks passed
@scouten scouten deleted the span+take_ident branch July 29, 2024 01:12
@scouten scouten mentioned this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant