Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track Flask 5XX responses as errors #390

Merged
merged 4 commits into from
Nov 25, 2019
Merged

Track Flask 5XX responses as errors #390

merged 4 commits into from
Nov 25, 2019

Conversation

adamchainz
Copy link
Contributor

Ref #383.

@adamchainz
Copy link
Contributor Author

WIP - there are many cases to handle from Flask, or we move to wrapping at a different function.

@adamchainz adamchainz changed the title Track Flask 5XX responses as errors [WIP] Track Flask 5XX responses as errors Nov 23, 2019
@adamchainz adamchainz changed the title [WIP] Track Flask 5XX responses as errors Track Flask 5XX responses as errors Nov 25, 2019
@adamchainz
Copy link
Contributor Author

Moved to wrapping one level up in full_dispatch_request. This has the side effect of tracking responses generated by preprocessors.

@adamchainz adamchainz merged commit f2a231d into master Nov 25, 2019
@adamchainz adamchainz deleted the issue_383_5xx_flask branch November 25, 2019 10:07
@adamchainz adamchainz mentioned this pull request Nov 29, 2019
Merged
adamchainz added a commit that referenced this pull request Nov 29, 2019
@adamchainz
Track Flask preprocess_request span (#395)
ce8276e 
Following #390 I realized it's possible to track this middleware-ish hook which might be of value to our Flask users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamchainz