Tidy API and add tests for compat #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
force-pushed
the
flatten_context
branch
2 times, most recently
from
a72d959 to
890617f
Compare
* Move 'text' into 'compat' * Add `__all__` in `api` so it's clearer what is intended to be the public API * Flatten the two Context classes into one, since it's only part of the API and used there now * Use `@classmethod` instead of `@staticmethod` for `Context`, which is slightly more pythonic (even moreso would be a plain function) * Add tests for compat, and update implementation of `datetime_to_timestamp` to be consistent on both Pythons 2 and 3 * Rewrite API tests to use `tracked_request` fixture and thus be smaller
adamchainz
force-pushed
the
flatten_context
branch
from
890617f to
f7705e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__all__inapiso it's clearer what is intended to be the public API@classmethodinstead of@staticmethodforContext, which is slightly more pythonic (even moreso would be a plain function)datetime_to_timestampto be consistent on both Pythons 2 and 3tracked_requestfixture and thus be smaller