disambiguate parameters (#204)

[ocramz]

Disambiguate request parameters (#204).

• Adjust the Env type to have three [Param] fields instead of one
• add captureParam, formParam, queryParam and the associated captureParams, formParams, queryParams.
• Add deprecation notices to param and params
• adjust examples and tests

[jfraudeau]

Nice to see these changes coming to scotty !
If I may add a comment, I'm not sure it makes sense to call next when parseParam fails for query and form parameters. I believe it would provide better errors to just return a "bad request" in these cases.

[ocramz]

Nice to see these changes coming to scotty ! If I may add a comment, I'm not sure it makes sense to call next when parseParam fails for query and form parameters. I believe it would provide better errors to just return a "bad request" in these cases.

@jfraudeau Could you share a permalink to where is this behaviour implemented? Thank you

[jfraudeau]

Sure : https://github.com/ocramz/scotty/blob/289ce9f9dc812edbeefaca0c773319d4d23a7675/Web/Scotty/Action.hs#L276

[ocramz]

@jfraudeau Good catch! But applying your suggestion would be a user-visible change, even though I don't know whether anybody actually relied on the current (buggy) behaviour or they simply worked around it.

[jfraudeau]

@ocramz I think it should be ok if the change only applies to the new formParams and queryParams

[ocramz]

I took a stab at it and added a few tests, @jfraudeau please take another look when you have time. Thanks!