Add support for twitter cards #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's only a small change and would not break the rest of the functionality in any way. @AramZS thanks for your work on this library! |
AramZS
added a commit
to AramZS/opengraph
that referenced
this pull request
Jul 12, 2016
Pulled from scottmac#25 with some corrections. Twitter advises the name attribute to set tags.
|
Hi @martinstuecklschwaiger I figured out why I couldn't get this to work, Twitter advises its tags be set with I've added code to check there for Twitter values and it works great now. I've added it to my forward master branch. Thanks! |
|
Thanks a lot. I'll close this PR then… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.