Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor projects #52

Merged
merged 2 commits into from
Oct 22, 2016
Merged

Refactor projects #52

merged 2 commits into from
Oct 22, 2016

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Oct 17, 2016

No description provided.

@StefH StefH mentioned this pull request Oct 17, 2016
Closed
@StefH
Copy link
Collaborator Author

StefH commented Oct 17, 2016

Please do a code-review.

@Thorium
Copy link
Collaborator

Thorium commented Oct 17, 2016

So now LinqKit.Core is basic (net standard) version with no references?
And LinqKit is a .NET45 version with EF6 and LinqKit.Core reference?

Looks good to me!

@StefH
Copy link
Collaborator Author

StefH commented Oct 17, 2016 •
edited
Loading

  • LinqKit.Core supports a lot of frameworks and has no reference to EntityFramework
  • LinqKit supports .NET 4.5.x and .NET 4.6.x but has no reference to LinqKit.Core, it uses the same C# source files. Referencing is not possible.

@Thorium
Copy link
Collaborator

Thorium commented Oct 17, 2016

Ok. Sounds ok for me still.

@StefH
Merge branch 'master'
9090a51 
Conflicts:
	src/LinqKit/AggregateBalanced.cs
	src/LinqKit/Utilities/TaskHelper.cs
@StefH
Copy link
Collaborator Author

StefH commented Oct 18, 2016

OK, I'll merge this PR?

@StefH
Copy link
Collaborator Author

StefH commented Oct 22, 2016

@Thorium : should I merge this PR and create new NuGets?

@Thorium
Copy link
Collaborator

Thorium commented Oct 22, 2016

I think you can.

@StefH StefH merged commit 0871958 into master Oct 22, 2016
@StefH StefH deleted the _stef_refactor_packages branch October 22, 2016 13:40
@StefH StefH mentioned this pull request Oct 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefH @Thorium