Fix for: Spkl writes connection string password to log file as a plain text when creating early bound types #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncluded in log file as a plain text.
…umed here that password is always given as "Password=" (in case insensitive form).
…character = defining the passcode.
|
This is released to NuGet in https://github.com/scottdurow/SparkleXrm/releases/tag/spkl-v1.0.441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spkl is used to generate early bound types spkl writes parameters given to CrmSvcUtil into log file. These parameters include connection string and in many cases this will include password. This happens also when spkl interactively asks connection string or password from user.
This PR adds masking functionality into task responsible of creating early bound classes. Call to this masking functionality is added to the point in code which writes parameters into log. Passcode is masked with four stars. Otherwise parameter string going to log is left intact.