Create CrcBuilder
#316
Merged
Create CrcBuilder
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilquist
reviewed
Sep 15, 2021
| @@ -49,6 +49,13 @@ object crc { | |||
| lazy val crc32c: BitVector => BitVector = | |||
| int32(0x1edc6f41, 0xffffffff, true, true, 0xffffffff).andThen(i => BitVector.fromInt(i)) | |||
|
|
|||
| /** An immutable "builder" to incrementally compute a CRC. | |||
| */ | |||
| sealed trait CrcBuilder[Out] { | |||
There was a problem hiding this comment.
I don't hold this opinion strongly but wdyt of using the names from collection library?
- rename
updateto+= - rename
outputtoresult
There was a problem hiding this comment.
Eh on second thought, I don't like that suggestion as this is immutable.
There was a problem hiding this comment.
for sure, these definitely need bike-shedding :)
- 👍
outputtoresult updateto+=: maybe as an alias? it's a bit confusing since we're not exactly "adding", is there some other symbol that could be more appropriate? Also, since it's immutable, I think we'd want+so that+=works if they store it in avar.
There was a problem hiding this comment.
Oops, just saw your followup comment. Yep!
There was a problem hiding this comment.
Btw, should update be updated? I think that's how they do immutable structures?
There was a problem hiding this comment.
👍 for updated and result
mpilquist
reviewed
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in typelevel/fs2#2606. This was pretty straightforward, just code shuffling.