-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing builds with CIBuildWheel #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 94.80% 94.80%
=======================================
Files 3 3
Lines 154 154
Branches 26 26
=======================================
Hits 146 146
Misses 7 7
Partials 1 1 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another attempt at fixing the failing build for linux wheels. The main github workflow has been updated to use modern actions and incorporates cibuildwheel to do the packaging. This PR also updates the github actions used in the CI/CD jobs (as well as a dependabot to ensure these stay up-to-date moving forward).
The results of this PR can be seen on test py pi here: https://test.pypi.org/project/ripser-test-1934/
There is a lot of flexibility in what wheels we can provide. As of now, wheels for python version 3.8 -- 3.12 for win32, win64, macosx_x86_64 and manylinux_x86_64 are provided. This can be adjusted as required fairly easily.
Before this PR can be accepted, a "Trusted Publisher" needs to be added to the pypi.org page for
ripser.py
. The current method is to use API tokens, but that practice has been deprecated (see here). That link contains directions on how to do that. I'm also happy to help do it but I currently do not have access on pypi.org.