Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing builds with CIBuildWheel #159

Merged
merged 27 commits into from
Mar 2, 2024

Conversation

catanzaromj
Copy link
Contributor

@catanzaromj catanzaromj commented Feb 27, 2024

This PR is another attempt at fixing the failing build for linux wheels. The main github workflow has been updated to use modern actions and incorporates cibuildwheel to do the packaging. This PR also updates the github actions used in the CI/CD jobs (as well as a dependabot to ensure these stay up-to-date moving forward).

The results of this PR can be seen on test py pi here: https://test.pypi.org/project/ripser-test-1934/

There is a lot of flexibility in what wheels we can provide. As of now, wheels for python version 3.8 -- 3.12 for win32, win64, macosx_x86_64 and manylinux_x86_64 are provided. This can be adjusted as required fairly easily.

Before this PR can be accepted, a "Trusted Publisher" needs to be added to the pypi.org page for ripser.py. The current method is to use API tokens, but that practice has been deprecated (see here). That link contains directions on how to do that. I'm also happy to help do it but I currently do not have access on pypi.org.

@catanzaromj catanzaromj requested a review from ctralie February 27, 2024 04:49
@catanzaromj catanzaromj self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (24c2f51) to head (5ed243b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files           3        3           
  Lines         154      154           
  Branches       26       26           
=======================================
  Hits          146      146           
  Misses          7        7           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@catanzaromj catanzaromj marked this pull request as ready for review February 28, 2024 19:26
@catanzaromj catanzaromj merged commit 35e7baf into scikit-tda:master Mar 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Install Errors in the installation process.
Projects
None yet
1 participant