Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change qmu API and remove test_stat return #712

Merged
merged 7 commits into from
Jan 3, 2020
Merged

feat: change qmu API and remove test_stat return #712

merged 7 commits into from
Jan 3, 2020

Conversation

lukasheinrich
Copy link
Contributor

@lukasheinrich lukasheinrich commented Dec 29, 2019 •
edited by matthewfeickert
Loading

Description

subchanges of #709

  • make qmu return a scalar
  • remove API to return test statistics from hypothesis tests (which only makes sense for asymptotics)
  • changes public API

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Make 'pyhf.infer.test_statistics.qmu' return a scalar
* Remove API to return test statistics from hypothesis tests (which only makes sense for asymptotics)

@lukasheinrich lukasheinrich changed the title change qmu API and remove test_stat return feat: change qmu API and remove test_stat return Dec 29, 2019
@lukasheinrich lukasheinrich added the bumpversion/patch Create a patch version release label Dec 29, 2019
@github-actions
Copy link

I've queued this up. When it gets merged, I'll create a patch release from v0.3.1 → v0.3.2 which includes the following 13 change(s) [including this PR]:

  • feat: change qmu API and remove test_stat return
  • fix: Correct order of Codecov reporting in CI
  • feat: Add contrib module
  • refactor: Use MLE API
  • ci: workflow that runs bumpversion and pushes when issue filed
  • feat: double precision for ML backends
  • docs: Add docstrings for interpolators
  • docs: Add Altair example notebook
  • docs: Add docstrings for src/pyhf/infer
  • feat: Add ENTRYPOINT to pyhf Docker image
  • ci: Use Python 3 scipy Alpine image for base Docker image
  • ci: Add Codecov threshold tolerance
  • chore: Remove top level 'examples' dir

    • If you make any more changes, you probably want to re-trigger me again by removing the bumpversion/patch label and then adding it back again.

    @codecov
    Copy link

    codecov bot commented Dec 29, 2019 •
    edited
    Loading

    Codecov Report

    Merging #712 into master will decrease coverage by <.01%.
    The diff coverage is 100%.

    Impacted file tree graph

    @@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   94.86%   94.86%   -0.01%     
==========================================
  Files          52       52              
  Lines        2765     2763       -2     
  Branches      393      392       -1     
==========================================
- Hits         2623     2621       -2     
  Misses         97       97              
  Partials       45       45
    Flag Coverage Δ
    #unittests 94.86% <100%> (-0.01%) ⬇️
    Impacted Files Coverage Δ
    src/pyhf/infer/test_statistics.py 100% <100%> (ø) ⬆️
    src/pyhf/infer/utils.py 100% <100%> (ø) ⬆️
    src/pyhf/infer/__init__.py 100% <100%> (ø) ⬆️

    Continue to review full report at Codecov.

    Legend - Click here to learn more
    Δ = absolute <relative> (impact), ø = not affected, ? = missing data
    Powered by Codecov. Last update 29c7e72...8fd4bbe. Read the comment docs.

    @lukasheinrich lukasheinrich requested review from kratsg and matthewfeickert and removed request for kratsg December 29, 2019 16:59
    @lukasheinrich lukasheinrich self-assigned this Dec 29, 2019
    @lukasheinrich lukasheinrich requested a review from kratsg December 29, 2019 17:09
    @lukasheinrich lukasheinrich mentioned this pull request Dec 29, 2019
    Closed
    4 tasks
    @matthewfeickert matthewfeickert added the feat/enhancement New feature or request label Dec 30, 2019
    @github-actions
    Copy link

    I've queued this up. When it gets merged, I'll create a patch release from v0.3.1 → v0.3.2 which includes the following 13 change(s) [including this PR]:

  • feat: change qmu API and remove test_stat return
  • fix: Correct order of Codecov reporting in CI
  • feat: Add contrib module
  • refactor: Use MLE API
  • ci: workflow that runs bumpversion and pushes when issue filed
  • feat: double precision for ML backends
  • docs: Add docstrings for interpolators
  • docs: Add Altair example notebook
  • docs: Add docstrings for src/pyhf/infer
  • feat: Add ENTRYPOINT to pyhf Docker image
  • ci: Use Python 3 scipy Alpine image for base Docker image
  • ci: Add Codecov threshold tolerance
  • chore: Remove top level 'examples' dir

    • If you make any more changes, you probably want to re-trigger me again by removing the bumpversion/patch label and then adding it back again.

    @matthewfeickert matthewfeickert added the API Changes the public API label Dec 30, 2019
    @github-actions
    Copy link

    I've queued this up. When it gets merged, I'll create a patch release from v0.3.1 → v0.3.2 which includes the following 13 change(s) [including this PR]:

  • feat: change qmu API and remove test_stat return
  • fix: Correct order of Codecov reporting in CI
  • feat: Add contrib module
  • refactor: Use MLE API
  • ci: workflow that runs bumpversion and pushes when issue filed
  • feat: double precision for ML backends
  • docs: Add docstrings for interpolators
  • docs: Add Altair example notebook
  • docs: Add docstrings for src/pyhf/infer
  • feat: Add ENTRYPOINT to pyhf Docker image
  • ci: Use Python 3 scipy Alpine image for base Docker image
  • ci: Add Codecov threshold tolerance
  • chore: Remove top level 'examples' dir

    • If you make any more changes, you probably want to re-trigger me again by removing the bumpversion/patch label and then adding it back again.

    matthewfeickert
    matthewfeickert approved these changes Dec 30, 2019
    View reviewed changes
    Copy link
    Member

    @matthewfeickert matthewfeickert left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I'm fine with all of these changes, and LGTM. Thanks! 👍

    @matthewfeickert matthewfeickert merged commit ed91b0a into master Jan 3, 2020
    @matthewfeickert matthewfeickert deleted the prep_calcs branch January 3, 2020 01:14
    kratsg pushed a commit that referenced this pull request Jan 3, 2020
    @actions-user
    Bump version: 0.3.1 → 0.3.2
    97f5ea9 
    Triggered by #712 via GitHub Actions.
    @kratsg
    Copy link
    Contributor

    kratsg commented Jan 12, 2020

    ok with these changes too

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @matthewfeickert matthewfeickert matthewfeickert approved these changes

    @kratsg kratsg Awaiting requested review from kratsg

    Assignees

    @lukasheinrich lukasheinrich

    Labels
    API Changes the public API bumpversion/patch Create a patch version release feat/enhancement New feature or request
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @lukasheinrich @kratsg @matthewfeickert