Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backport): Replace deprecated np.product by np.prod #2284

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 16, 2023

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport PR https://github.com/scikit-hep/pyhf/pull/2242
* Use np.prod API over np.product as np.product is deprecated
  as of NumPy v1.25.0.
   - c.f. https://numpy.org/devdocs/release/1.25.0-notes.html#deprecations

* Backport PR #2242
* Use np.prod API over np.product as np.product is deprecated
  as of NumPy v1.25.0.
   - c.f. https://numpy.org/devdocs/release/1.25.0-notes.html#deprecations
@matthewfeickert matthewfeickert added fix A bug fix backport Backport PRs from main to release branch labels Aug 16, 2023
@matthewfeickert matthewfeickert self-assigned this Aug 16, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.7.x@3639975). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.7.x    #2284   +/-   ##
=================================================
  Coverage                  ?   98.23%           
=================================================
  Files                     ?       69           
  Lines                     ?     4538           
  Branches                  ?      801           
=================================================
  Hits                      ?     4458           
  Misses                    ?       47           
  Partials                  ?       33           
Flag Coverage Δ
contrib 27.54% <0.00%> (?)
doctest 61.06% <0.00%> (?)
unittests-3.10 96.27% <0.00%> (?)
unittests-3.11 96.27% <0.00%> (?)
unittests-3.7 96.25% <0.00%> (?)
unittests-3.8 96.29% <0.00%> (?)
unittests-3.9 96.31% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 5b58c2e into release/v0.7.x Aug 16, 2023
@matthewfeickert matthewfeickert deleted the backport/numpy-prod branch August 16, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants