fix: Pass script_runner commands as a single sequence #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pytest-console-scripts v1.4.0 introduces DeprecationWarning: script_runner commands should be passed as a single sequence, not as multiple arguments. Replace `script_runner.run(a, b, c)` calls with `script_runner.run([a, b, c])`
matthewfeickert
added
tests
matthewfeickert
added
the
build
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2221 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 69 69
Lines 4533 4533
Branches 802 802
=======================================
Hits 4456 4456
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team. |
4 tasks
matthewfeickert
removed
the
need-to-backport
matthewfeickert
added a commit
that referenced
this pull request
May 23, 2023
* Backport PR #2221 * Require pytest-console-scripts v1.4.0+ in 'test' extra. pytest-console-scripts v1.4.0 introduces a DeprecationWarning: > script_runner commands should be passed as a single sequence, not as multiple arguments. > Replace `script_runner.run(a, b, c)` calls with `script_runner.run([a, b, c])` * Remove unpacking of the command to be passed to script_runner with shlex.split to pass a list and not multiple arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pytest-console-scriptsv1.4.0+intestextra.pytest-console-scriptsv1.4.0introduces aDeprecationWarning:script_runnerwithshlex.splitto pass a list and not multiple arguments.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: