-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add FAQ on backend support on Apple silicon Macs #2118
Conversation
Codecov ReportBase: 98.05% // Head: 98.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2118 +/- ##
==========================================
+ Coverage 98.05% 98.30% +0.24%
==========================================
Files 69 69
Lines 4531 4531
Branches 645 645
==========================================
+ Hits 4443 4454 +11
+ Misses 54 45 -9
+ Partials 34 32 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also install tensorflow-macos
(and tensorflow-metal
) via pip
, but I guess that's discussed in the issue you linked anyway.
Ah yeah I had forgotten about the Metal project to get TensorFlow to work on Mac GPUs. Thanks for the reminder, I'll mention something about them. Though I guess related to that, @alexander-held on your Apple silicon Mac are you able to do the following in your virtual environment that you tried to use for developing in Issue #2111?
Or given this comment tensorflow/tensorflow#57185 (comment) about |
Ah, no I realize that this will fail regardless. Even though
invokes the Lines 64 to 67 in 29fb68e
and so it will still try to do a Normally this is where we would have some code to dynamically change determine the package name to use here based off of |
To install the dependencies for the TensorFlow backend you'll need to manually | ||
specify that ``tensorflow-macos`` is required | ||
|
||
.. code-block:: console | ||
|
||
python -m pip install pyhf tensorflow-macos tensorflow-probability | ||
|
||
Similarly, if you want to install the TensorFlow backend dependencies along with the | ||
other backends included in the ``[backends]`` extra you'll need to specify the extras | ||
as well | ||
|
||
.. code-block:: console | ||
|
||
python -m pip install 'pyhf[torch,jax,minuit]' tensorflow-macos tensorflow-probability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-held I think this should work to actually get things installed. Though I think it is going to be annoying to get a full developer environment setup at the moment given that the test
extra also pulls in the backends
extra and so will break here.
* At the moment, TensorFlow does not have Apple silicon compatible wheels on PyPI. As an alternative, not that conda-forge has linux-64 and osx-arm64 compatible releases for all of pyhf's backends. - c.f. https://github.com/tensorflow/tensorflow/issues 57185
4a8a6de
to
a02c668
Compare
This PR should no longer be needed as PR #2119 can work. |
Description
Superseded by PR #2119
Resolves #2111
At the moment, TensorFlow does not have Apple silicon compatible wheels on PyPI under the
tensorflow
project namespace, though it does undertensorflow-macos
. As an alternative, note that conda-forge haslinux-64
,osx-64
, andosx-arm64
compatible releases for all of pyhf's backends.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: