Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Loosen tolerance for test_validation[1bin_normsys_mu1] #2085

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Dec 21, 2022

Description

Loosen the relative tolerance from ~1e-9 to ~1e-6 to have comparisons with NumPy v1.24.0+ work. A relative tolerance of ~1e-6 is still fine and so this shouldn't be considered a regression.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Loosen the relative tolerance from ~1e-9 to ~1e-6 to have comparisons with
  NumPy v1.24.0+ work. A relative tolerance of ~1e-6 is still fine and so this
  shouldn't be considered a regression.

* Loosen the relative tolerance from ~1e-9 to ~1e-6 to have comparisons
  with NumPy v1.24.0+ work. A relative tolerance of ~1e-6 is still fine
  and so this shouldn't be considered a regression.
@matthewfeickert matthewfeickert added tests pytest fix A bug fix labels Dec 21, 2022
@matthewfeickert matthewfeickert self-assigned this Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 98.30% // Head: 98.30% // No change to project coverage 👍

Coverage data is based on head (8cfab8a) compared to base (78c0da0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2085   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4531     4531           
  Branches      645      645           
=======================================
  Hits         4454     4454           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.15% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lukasheinrich
Copy link
Contributor

LGTM

@matthewfeickert matthewfeickert merged commit 549b598 into main Dec 21, 2022
@matthewfeickert matthewfeickert deleted the fix/update-validation-variance branch December 21, 2022 13:31
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
* Add try-except block to determine what JAX array API is available and use this
  information to set the jax backend array_type and array_subtype.
* Backport components of:
   - PR #2079
   - PR #2085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants