Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disallow ipython v8.7.0 to avoid Pygments lexer warning #2068

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 29, 2022

Description

Resolves #2067

Disallow ipython v8.7.0 to avoid Pygments warning

WARNING: Pygments lexer name 'ipython3' is not known

which arises during the docs build. This is a stopgap measure and this line should be removed as soon as there is a resolution and new ipython release.

c.f. ipython/ipython#13845

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Disallow ipython v8.7.0 to avoid Pygments warning

> WARNING: Pygments lexer name 'ipython3' is not known

which arises during the docs build. This is a stopgap measure and this
line should be removed as soon as there is a resolution and new ipython
release.
   - c.f. https://github.com/ipython/ipython/issues/13845

* Disallow ipython v8.7.0 to avoid Pygments warning

> WARNING: Pygments lexer name 'ipython3' is not known

which arises during the docs build. This is a stopgap measure and this
line should be removed as soon as there is a resolution and new ipython
release.

c.f. https://github.com/ipython/ipython/ issue 13845
@matthewfeickert matthewfeickert added the docs Documentation related label Nov 29, 2022
@matthewfeickert matthewfeickert self-assigned this Nov 29, 2022
@matthewfeickert matthewfeickert added the fix A bug fix label Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 98.30% // Head: 98.30% // No change to project coverage 👍

Coverage data is based on head (c61ea57) compared to base (f6d1997).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2068   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4530     4530           
  Branches      645      645           
=======================================
  Hits         4453     4453           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.14% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 3eac67a into main Nov 29, 2022
@matthewfeickert matthewfeickert deleted the fix/dissallow-ipython-8-7-0 branch November 29, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

docs build failing on Pygments lexter warning
1 participant