feat: Add support for _ModelConfig.set_poi(None) to unset model POI
#1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratsg
requested review from
alexander-held,
lukasheinrich and
matthewfeickert
Codecov ReportBase: 98.25% // Head: 98.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1985 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 68 68
Lines 4416 4420 +4
Branches 726 727 +1
=======================================
+ Hits 4339 4343 +4
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
matthewfeickert
changed the title
_ModelConfig.set_poi(None) to unset model POI
matthewfeickert
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
LGTM. 👍 Thanks for being so fast on this @kratsg and for the quick iteration @alexander-held.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Resolves #1984 by allowing
_ModelConfig.set_poi(None)to be allowed behavior to remove the POI from a model.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: