-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update lower bounds to tensorflow v2.7.0, jaxlib v0.1.61 #1962
Conversation
* Update lower bound of the supported typing-extensions versions to v3.7.4.3 to ensure SupportsIndex is available, which is used as of PR 1940.
* tensorflow v2.6.5 restricts numpy to 'numpy~=1.19.2' but numpy.typing was not added until numpy v1.20.0. For typing of the numpy backend to work as added in PR 1940, tensorflow v2.7.0+ is required where tensorflow relaxes numpy constraints to 'numpy>=1.14.5'.
jaxlib v1.60.0 required 'numpy>=1.12,<1.20' but jaxlib v1.60.1 requires 'numpy>=1.16'.
Codecov Report
@@ Coverage Diff @@
## master #1962 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 68 68
Lines 4380 4380
Branches 728 728
=======================================
Hits 4303 4303
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
You could alternatively hide |
This is true, but if we bump these two lower bounds then we also unlock |
okay with it |
Description
tensorflow
v2.6.5
restrictsnumpy
tonumpy~=1.19.2
butnumpy.typing
was not added untilnumpy
v1.20.0
. For typing of the NumPy backend to work as added in PR feat: Add typehints to pyhf.tensor #1940,tensorflow
v2.7.0+
is required, wheretensorflow
relaxesnumpy
constraints tonumpy>=1.14.5
.jaxlib
v0.1.60
requirednumpy>=1.12,<1.20
butjaxlib
v0.1.61
requiresnumpy>=1.16
.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: