Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update lower bounds to tensorflow v2.7.0, jaxlib v0.1.61 #1962

Merged
merged 10 commits into from
Aug 27, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 26, 2022

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update lower bound of the supported tensorflow versions to v2.7.0 to ensure
  numpy v1.20.0+ is available.
   - numpy.typing is needed for PR #1940 and was added in numpy v1.20.0.
   - tensorflow v2.6.5 restricts numpy to 'numpy~=1.19.2' and tensorflow v2.7.0
     relaxes numpy constraints to 'numpy>=1.14.5'.
* Update lower bound of the supported jaxlib versions to v0.1.61.
   - jaxlib v0.1.60 required 'numpy>=1.12,<1.20' and jaxlib v0.1.61 relaxes this
     to 'numpy>=1.16'.
* Update tests/constraints.txt to use tensorflow==2.7.0 and jaxlib==0.1.61.

* Update lower bound of the supported typing-extensions versions to v3.7.4.3
  to ensure SupportsIndex is available, which is used as of PR 1940.
* tensorflow v2.6.5 restricts numpy to 'numpy~=1.19.2' but numpy.typing
  was not added until numpy v1.20.0. For typing of the numpy backend to
  work as added in PR 1940, tensorflow v2.7.0+ is required where
  tensorflow relaxes numpy constraints to 'numpy>=1.14.5'.
jaxlib v1.60.0 required 'numpy>=1.12,<1.20' but jaxlib v1.60.1 requires
'numpy>=1.16'.
@matthewfeickert matthewfeickert added fix A bug fix build Changes that affect the build system or external dependencies labels Aug 26, 2022
@matthewfeickert matthewfeickert self-assigned this Aug 26, 2022
@matthewfeickert matthewfeickert temporarily deployed to github-pages August 26, 2022 20:07 Inactive
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1962 (1d184f1) into master (a92d9b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1962   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          68       68           
  Lines        4380     4380           
  Branches      728      728           
=======================================
  Hits         4303     4303           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 26.55% <ø> (ø)
doctest 60.54% <ø> (ø)
unittests-3.10 96.14% <ø> (ø)
unittests-3.7 96.12% <ø> (ø)
unittests-3.8 96.16% <ø> (ø)
unittests-3.9 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kratsg kratsg temporarily deployed to github-pages August 26, 2022 21:06 Inactive
@kratsg
Copy link
Contributor

kratsg commented Aug 26, 2022

You could alternatively hide numpy.typing in the TYPE_CHECKING and install a newer version of numpy just for mypy.

@matthewfeickert matthewfeickert temporarily deployed to github-pages August 26, 2022 21:17 Inactive
@matthewfeickert
Copy link
Member Author

You could alternatively hide numpy.typing in the TYPE_CHECKING and install a newer version of numpy just for mypy.

This is true, but if we bump these two lower bounds then we also unlock numpy from being kept below v1.20 which allows for more flexibility in a lot of environment solves. So I personally don't mind bumping these if you're okay with it.

@matthewfeickert matthewfeickert marked this pull request as ready for review August 26, 2022 21:31
@matthewfeickert matthewfeickert changed the title build: Update lower bounds to tensorflow v2.7.0, jaxlib v1.60.1 build: Update lower bounds to tensorflow v2.7.0, jaxlib v0.1.61 Aug 26, 2022
@matthewfeickert matthewfeickert temporarily deployed to github-pages August 26, 2022 21:37 Inactive
@matthewfeickert
Copy link
Member Author

Passing now on workflow dispatch

pass

@kratsg
Copy link
Contributor

kratsg commented Aug 26, 2022

if you're okay with it.

okay with it

@matthewfeickert matthewfeickert merged commit 868c27d into master Aug 27, 2022
@matthewfeickert matthewfeickert deleted the build/update-tensorflow-lower-bound branch August 27, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants