Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set lower bound of typing-extensions to v3.7.4 #1938

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 12, 2022

Description

Add a lower bound of the supported typing_extensions version to v3.7.4 as TypedDict was added in v3.7.4.

The typing_extensions module contains both backports of these changes as well as experimental types that will eventually be added to the typing module, such as Protocol or TypedDict.

Amends PR #1934.

Example:

(venv) $ python -m pip --quiet install 'typing-extensions==3.7.2' && python -c 'from typing_extensions import Literal, TypedDict' && echo $?
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: cannot import name 'TypedDict' from 'typing_extensions' (/venv/lib/python3.7/site-packages/typing_extensions.py)
(venv) $ python -m pip --quiet install 'typing-extensions==3.7.4' && python -c 'from typing_extensions import Literal, TypedDict' && echo $?
0

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Set the lower bound of the supported typing_extensions versions to v3.7.4
  as TypedDict was added in v3.7.4.

  > The typing_extensions module contains both backports of these changes as
  > well as experimental types that will eventually be added to the typing module,
  > such as Protocol or TypedDict.
   - c.f. https://pypi.org/project/typing-extensions/3.7.4/

   - Amends PR #1934
* Add typing-extensions==3.7.4 to tests/constraints.txt.

* Set the lower bound of the supported typing_extensions versions to v3.7.4
  as TypedDict was added in v3.7.4.

  > The typing_extensions module contains both backports of these changes as
  > well as experimental types that will eventually be added to the typing module,
  > such as Protocol or TypedDict.
   - c.f. https://pypi.org/project/typing-extensions/3.7.4/
@matthewfeickert matthewfeickert added the build Changes that affect the build system or external dependencies label Aug 12, 2022
@matthewfeickert matthewfeickert self-assigned this Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1938 (46ace0d) into master (dcbd9ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1938   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          69       69           
  Lines        4439     4439           
  Branches      748      748           
=======================================
  Hits         4362     4362           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 25.81% <ø> (ø)
doctest 61.02% <ø> (ø)
unittests-3.10 96.14% <ø> (ø)
unittests-3.7 96.13% <ø> (ø)
unittests-3.8 96.17% <ø> (ø)
unittests-3.9 96.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matthewfeickert
Copy link
Member Author

Given that the minimum supported dependencies workflow has tests/test_import.py passing, then this should be good to go.

tests-pass

@kratsg kratsg merged commit ca77a63 into master Aug 12, 2022
@kratsg kratsg deleted the build/set-typing-extensions-lower-bound branch August 12, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants