Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Report coverage for all Python versions #1936

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 12, 2022

Description

Remove check to only report coverage to Codecov for the oldest Python (Python 3.7) and newest (Python 3.10) tested

python-version: ['3.7', '3.8', '3.9', '3.10']

and instead report the coverage for all versions. The coverage flag for Codecov is unittests-${{ matrix.python-version }} and so the Codecov report will now show coverage for all versions and not just the 'bookend' versions.

uses: codecov/codecov-action@v3
with:
files: ./coverage.xml
flags: unittests-${{ matrix.python-version }}

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove check to only report coverage to Codecov for the oldest Python
(Python 3.7) and newest (Python 3.10) tested and instead report
the coverage for all versions. The coverage flag for Codecov is
'unittests-${{ matrix.python-version }}' and so the Codecov report
will now show coverage for all versions and not just the 'bookend'
versions.

* Remove check to only report coverage to Codecov for the oldest Python
(Python 3.7) and newest (Python 3.10) tested and instead report
the coverage for all versions. The coverage flag for Codecov is
'unittests-${{ matrix.python-version }}' and so the Codecov report
will now show coverage for all versions and not just the 'bookend'
versions.
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Aug 12, 2022
@matthewfeickert matthewfeickert self-assigned this Aug 12, 2022
@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1936 (cb32eb7) into master (97664bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1936   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files          68       68           
  Lines        4365     4365           
  Branches      734      734           
=======================================
  Hits         4286     4286           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.25% <ø> (ø)
doctest 60.50% <ø> (ø)
unittests-3.10 96.08% <ø> (ø)
unittests-3.7 96.06% <ø> (ø)
unittests-3.8 96.10% <ø> (?)
unittests-3.9 96.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matthewfeickert matthewfeickert requested a review from kratsg August 12, 2022 05:20
@kratsg kratsg merged commit 3295d86 into master Aug 12, 2022
@kratsg kratsg deleted the ci/report-coverage-for-all-pythons branch August 12, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants