Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use github.workflow property to ensure unique concurrency group #1879

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 7, 2022

Description

Use github.workflow property to ensure that the concurrency group id from ${{ github.workflow }}-${{ github.ref }} is unique to the workflow.
c.f. Example: Only cancel in-progress jobs or runs for the current workflow

This also simplifies maintenance as it is removes unique names that need to be manually searched for.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use github.workflow property to ensure that the concurrency group id from
`${{ github.workflow }}-${{ github.ref }}` is unique to the workflow.
   - c.f. https://docs.github.com/en/actions/using-jobs/using-concurrency

* Use github.workflow property to ensure that the concurrency group
id from `${{ github.workflow }}-${{ github.ref }}` is unique to the
workflow.
   - c.f. https://docs.github.com/en/actions/using-jobs/using-concurrency
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Jun 7, 2022
@matthewfeickert matthewfeickert self-assigned this Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1879 (87737cb) into master (aed69b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1879   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          68       68           
  Lines        4322     4322           
  Branches      726      726           
=======================================
  Hits         4243     4243           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.39% <ø> (ø)
doctest 60.73% <ø> (ø)
unittests-3.10 96.04% <ø> (ø)
unittests-3.7 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed69b5...87737cb. Read the comment docs.

@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Jun 7, 2022
@matthewfeickert
Copy link
Member Author

As other maintainers are on holiday, I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 4682725 into master Jun 7, 2022
@matthewfeickert matthewfeickert deleted the ci/use-github-workflow branch June 7, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant