Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update developer documentation #1847

Merged
merged 14 commits into from
Apr 20, 2022
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 12, 2022

Description

Following PR #1846, update the developer documentation to reflect the tbump workflow and general workflow updates.

Main bits:

  • Update the developer docs to make some core dev team working knowledge explicit and hopefully make onboarding new developers easier.
  • Advocate for use of SSH keys for GitHub, which is easier to suggest now that GitHub has removed password authentication.
  • Split the testing section into writing and running tests and give explicit commands for running various types of tests.
  • Describe the tbump tag generation procedure added in PR ci: Add bump version workflow for release tags #1846.
  • Summarize deployment to TestPyPI and PyPI in a Deployment subsection under the Publishing section.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update the developer docs to make some core dev team working knowledge
explicit and hopefully make onboarding new developers easier.
* Advocate for use of SSH keys for GitHub, which is easier to suggest
now that GitHub has removed password authentication.
   - c.f. https://github.blog/2021-09-01-improving-git-protocol-security-github/
* Split the testing section into writing and running tests and give explicit
commands for running various types of tests.
* Describe the tbump tag generation procedure added in PR #1846.
* Summarize deployment to TestPyPI and PyPI in a Deployment subsection under
the Publishing section.

@matthewfeickert matthewfeickert added the docs Documentation related label Apr 12, 2022
@matthewfeickert matthewfeickert self-assigned this Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1847 (c8e8a5d) into master (1cf0ac6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1847   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          68       68           
  Lines        4315     4315           
  Branches      725      725           
=======================================
  Hits         4236     4236           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.44% <ø> (ø)
doctest 60.78% <ø> (ø)
unittests-3.10 96.03% <ø> (ø)
unittests-3.7 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf0ac6...c8e8a5d. Read the comment docs.

@matthewfeickert
Copy link
Member Author

@matthewfeickert matthewfeickert marked this pull request as ready for review April 13, 2022 17:36
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Apr 13, 2022

Something cool that I learned while writing this is that pytest-mpl has a --mpl-generate-summary html option that will make very nice comparison visuals for you!

So

pytest tests/contrib --mpl --mpl-baseline-path tests/contrib/baseline --mpl-generate-summary html

will make the following website

visualize

👍

@andrzejnovak did you know about this?

@matthewfeickert matthewfeickert changed the title docs: Update developer documenation docs: Update developer documentation Apr 13, 2022
@andrzejnovak
Copy link
Member

Neat, I think this is a new feature, at least since I've set up the test suite for mplhep.

@matthewfeickert matthewfeickert marked this pull request as draft April 20, 2022 06:50
@matthewfeickert matthewfeickert marked this pull request as ready for review April 20, 2022 06:50
@matthewfeickert matthewfeickert merged commit afa49e0 into master Apr 20, 2022
@matthewfeickert matthewfeickert deleted the docs/update-dev-docs branch April 20, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants