ci: Skip doctest for 'Minimum supported dependencies' workflow #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 63 63
Lines 4050 4050
Branches 576 576
=======================================
Hits 3957 3957
Misses 54 54
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
matthewfeickert
commented
Sep 4, 2021
| - name: Test with pytest | ||
| run: | | ||
| python -m pytest -r sx --ignore tests/benchmarks/ --ignore tests/contrib --ignore tests/test_notebooks.py | ||
| # Run on tests/ to skip doctests of src given examples are for latest APIs | ||
| python -m pytest -r sx --ignore tests/benchmarks/ --ignore tests/contrib --ignore tests/test_notebooks.py tests/ |
There was a problem hiding this comment.
Okay, cool. This is ready for review then. :)
|
I'm going to just merge this as it should be uncontroversial as it is extra tests, but let me know if anyone wants changes made in another PR. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run pytest explicitly over the tests/ directory only to avoid in the 'Minimum supported dependencies' workflow to avoid running doctest on the docstring examples. The latest version of the JAX docsting examples have some print failures that are incompatible with the older versions of JAX, even thought the API tests pass.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: