-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add developer release checklist Issue template #1493
docs: Add developer release checklist Issue template #1493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 63 63
Lines 4006 4006
Branches 565 565
=======================================
Hits 3912 3912
Misses 55 55
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Relevant page for review: https://pyhf--1493.org.readthedocs.build/en/1493/development.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add an ISSUE_TEMPLATE for release checklist instead? I'm not sure it needs to be added to the docs explicitly but...
Yeah, that's a much better idea. I originally had this as part of a PR comment, but then changed to an Issue. I'll fix this up. 👍 |
Probably easiest way to review online is to read here: https://github.com/scikit-hep/pyhf/blob/docs/add-developer-release-checklist/.github/ISSUE_TEMPLATE/~release-checklist.md |
36189e3
to
018666e
Compare
Description
Resolves #1319
Add a developer release checklist Issue Template to make sure that steps don't get missed during the release and to formalize the release so that any member of the developer team can do it.
Restrict the issue template to project maintainers only. c.f. https://github.com/pypa/pip/blob/e6414d6db6db37951988f6f2b11ec530ed0b191d/.github/ISSUE_TEMPLATE/~good-first-issue.md for an example.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: