Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use _version.py to follow setuptools_scm recommendations #1480

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 1, 2021

Description

Following pypa/setuptools-scm#576 change the generated version file (c.f. PR #1450) to be named _version.py

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Rename generated version file from version.py to _version.py following setuptools_scm recommendations
   - c.f. https://github.com/pypa/setuptools_scm/pull/576
   - Avoids publishing the contents of "version.py" as externally visible API
* Amends PR #1450

@matthewfeickert matthewfeickert added chore Other changes that don't modify src or test files packaging setup.py, setup.cfg, pyproject.toml, and friends labels Jun 1, 2021
@matthewfeickert matthewfeickert self-assigned this Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #1480 (ba6996d) into master (2272410) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          63       63           
  Lines        4006     4006           
  Branches      565      565           
=======================================
  Hits         3912     3912           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
contrib 25.51% <100.00%> (ø)
unittests 97.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/__init__.py 98.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2272410...ba6996d. Read the comment docs.

@matthewfeickert
Copy link
Member Author

@kratsg I'm just going to merge this to move forward (I know that you're circumstantially extra busy this week) but please make any comments if you'd like something changed. I'm happy to revert or make a fix PR.

@matthewfeickert matthewfeickert merged commit 6d3ff05 into master Jun 2, 2021
@matthewfeickert matthewfeickert deleted the chore/follow-change-to-_version branch June 2, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files packaging setup.py, setup.cfg, pyproject.toml, and friends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant