Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: __array__ is no longer allowed on NumpyArray and EmptyArray #2997

Merged
merged 3 commits into from
Feb 2, 2024
Merged

feat!: __array__ is no longer allowed on NumpyArray and EmptyArray #2997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2e5157
feat!: __array__ is no longer allowed on NumpyArray and EmptyArray
jpivarski Feb 1, 2024
1f70c00
Merge branch 'main' into jpivarski/__array__-is-no-longer-allowed-on-…
agoose77 Feb 2, 2024
574b69e
Merge branch 'main' into jpivarski/__array__-is-no-longer-allowed-on-…
jpivarski Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/awkward/contents/emptyarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from awkward._backends.backend import Backend
from awkward._backends.numpy import NumpyBackend
from awkward._backends.typetracer import TypeTracerBackend
from awkward._errors import deprecate
from awkward._layout import maybe_posaxis
from awkward._meta.emptymeta import EmptyMeta
from awkward._nplikes.array_like import ArrayLike
Expand Down Expand Up @@ -110,13 +109,6 @@ def __copy__(self):
def __deepcopy__(self, memo):
return self.copy()

def __array__(self, dtype=None):
deprecate(
f"np.asarray(content) is deprecated for {type(self).__name__}. Use ak.to_numpy(content) instead",
version="2.6.0",
)
return numpy.empty(0, dtype=dtype)

@classmethod
def simplified(cls, *, parameters=None, backend=None):
if not (parameters is None or len(parameters) == 0):
Expand Down
8 changes: 0 additions & 8 deletions src/awkward/contents/numpyarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from awkward._backends.dispatch import backend_of_obj
from awkward._backends.numpy import NumpyBackend
from awkward._backends.typetracer import TypeTracerBackend
from awkward._errors import deprecate
from awkward._layout import maybe_posaxis
from awkward._meta.numpymeta import NumpyMeta
from awkward._nplikes import to_nplike
Expand Down Expand Up @@ -166,13 +165,6 @@ def __deepcopy__(self, memo):
parameters=copy.deepcopy(self._parameters, memo),
)

def __array__(self, dtype=None):
deprecate(
f"np.asarray(content) is deprecated for {type(self).__name__}. Use ak.to_numpy(content) instead",
version="2.6.0",
)
return numpy.asarray(self._data, dtype=dtype)

@classmethod
def simplified(cls, data, *, parameters=None, backend=None):
return cls(data, parameters=parameters, backend=backend)
Expand Down
Loading