fix: strip epoch from SKBUILD_PROJECT_VERSION #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 83.66% 83.66%
=======================================
Files 74 74
Lines 4200 4200
=======================================
Hits 3514 3514
Misses 686 686 ☔ View full report in Codecov by Sentry. |
henryiii
added a commit
that referenced
this pull request
Jul 29, 2024
See #828. CMake will not understand the epoch, so not including it. It's still in `SKBUILD_PROJECT_FULL_VERSION`. Signed-off-by: Henry Schreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #828. CMake will not understand the epoch, so not including it. It's still in
SKBUILD_PROJECT_FULL_VERSION.