Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: if failed (retry) #820

Merged
merged 3 commits into from
Jul 22, 2024
Merged

feat: if failed (retry) #820

merged 3 commits into from
Jul 22, 2024

Conversation

henryiii
Copy link
Collaborator

One of the steps for #112.

@henryiii henryiii force-pushed the henryiii/feat/if.failed branch from 45ac803 to f014420 Compare July 19, 2024 22:15
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 96.38554% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (9bc0d97) to head (418e449).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
...cikit_build_core/settings/skbuild_read_settings.py 97.01% 2 Missing ⚠️
src/scikit_build_core/build/wheel.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   83.22%   83.67%   +0.45%     
==========================================
  Files          73       73              
  Lines        4077     4123      +46     
==========================================
+ Hits         3393     3450      +57     
+ Misses        684      673      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii force-pushed the henryiii/feat/if.failed branch from f014420 to 5291db7 Compare July 19, 2024 22:45
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/feat/if.failed branch from 5291db7 to ae4697f Compare July 20, 2024 01:11
henryiii added 2 commits July 21, 2024 01:06
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii merged commit 681e6a2 into main Jul 22, 2024
51 checks passed
@henryiii henryiii deleted the henryiii/feat/if.failed branch July 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant