Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nicer error/warning printer #813

Merged
merged 2 commits into from
Jul 16, 2024
Merged

chore: nicer error/warning printer #813

merged 2 commits into from
Jul 16, 2024

Conversation

henryiii
Copy link
Collaborator

Clean up warning/error printout. Warnings are not repeated.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/chore/warnerr branch from dd7b9f2 to 838e343 Compare July 16, 2024 03:10
Signed-off-by: Henry Schreiner <[email protected]>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.18%. Comparing base (c299548) to head (2439b23).
Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
...cikit_build_core/settings/skbuild_read_settings.py 36.84% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
+ Coverage   82.98%   83.18%   +0.19%     
==========================================
  Files          73       73              
  Lines        4074     4068       -6     
==========================================
+ Hits         3381     3384       +3     
+ Misses        693      684       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit a805267 into main Jul 16, 2024
51 checks passed
@henryiii henryiii deleted the henryiii/chore/warnerr branch July 16, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant