Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support older versions of setuptools_scm #390

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jun 21, 2023

Fix #387. We were importing this correctly in __init__.py, but missed this in a couple of other places. Removed from .pyi file to have mypy find this in the future.

@henryiii henryiii merged commit e292e7c into main Jun 21, 2023
@henryiii henryiii deleted the henryiii/fix/oldscm branch June 21, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail: ImportError: cannot import name '__version__' from 'scikit_build_core._version'
1 participant