Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add downstream examples #363

Merged
merged 3 commits into from
Jun 10, 2023
Merged

tests: add downstream examples #363

merged 3 commits into from
Jun 10, 2023

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jun 9, 2023

Adding some downstream examples, lightly tested in CI.

@LecrisUT
Copy link
Collaborator

LecrisUT commented Jun 9, 2023

If you're ok with moving .fmf folder to top level, I can add these examples as smoke tests for fedora packaging (both copr and downstream).

@henryiii
Copy link
Collaborator Author

henryiii commented Jun 9, 2023

Not ideal, but sure.

@henryiii
Copy link
Collaborator Author

henryiii commented Jun 9, 2023

(though you'll probably need to make sure they have --no-build-isolation to ensure you test against the current version of scikit-build-core)

@henryiii
tests: add downstream examples
68fdba1 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/tests/docs_extra_projects branch from 6aab3ae to 68fdba1 Compare June 9, 2023 22:04
@henryiii henryiii merged commit aaa01af into main Jun 10, 2023
@henryiii henryiii deleted the henryiii/tests/docs_extra_projects branch June 10, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @LecrisUT