-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration guide #356
Add migration guide #356
Conversation
If it helps, I've recently helped wjakob/nanobind_example and kratsg/pylibmagic#48 convert. There's a PR to scikit-build/cmake_python_distributions too. |
Thanks for the review @henryiii! Before I go any further, do you agree that something like this guide could be helpful? Happy to continue investing time in it if you're interested since I will be effectively compiling this list for my own use anyway.
Thanks for the pointer. I know there were a couple other early conversions too (like awkward array) that I could look at. FWIW I've got a handful of different projects that will all probably migrate roughly in lockstep, and while they are largely similar I'll probably be playing it safe and testing many/most of them before merging the migrations. So I may end up providing you with even more data points (not sure how many projects you already have on scikit-build-core now though!). |
Sure! Eventually it might just be a guide for converting from setuptools (possibly + CMake manually added) though, once most projects have converted from scikit-build classic. But that's well in the future. |
There will also be a weird transition back when |
It will try to behave like the old scikit-build, though, and it still will work through setuptools (which is not ideal); a lot of the features you don't get access to (like auto cmake/ninja download) unless you switch to the new interface. |
Co-authored-by: Henry Schreiner <[email protected]>
4cb7b49
to
668fb4e
Compare
Thanks! |
Adding a page to the documentation about migrating from scikit-build classic. I'll keep updating this as I discover more while migrating various repos, then open it for review when I've found everything I expect to find.