Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGES: Reference changes introduced in pull-request #73 #74

Merged
merged 1 commit into from
Nov 14, 2023
Merged

CHANGES: Reference changes introduced in pull-request #73 #74

merged 1 commit into from
Nov 14, 2023

Conversation

jcfr
Copy link
Collaborator

@jcfr jcfr commented Nov 14, 2023 •
edited
Loading

Reference changes introduced in pull-request:

@jcfr
Copy link
Collaborator Author

jcfr commented Nov 14, 2023 •
edited
Loading

@offbyone Does the description of the changes seem reasonable ?

🙏 Thanks for taking the time to review. Once this is integrated, we will create a new release.

offbyone
offbyone approved these changes Nov 14, 2023
View reviewed changes
Copy link

@offbyone offbyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcfr jcfr merged commit eaec743 into scikit-build:master Nov 14, 2023
@jcfr
Copy link
Collaborator Author

jcfr commented Nov 14, 2023

I will release once I get back on the computer in the next hour or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offbyone offbyone offbyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfr @offbyone