fix: simplify and prepare for next release #301
Conversation
| @@ -20,10 +20,11 @@ | |||
| <App | |||
| header={false} | |||
| deps={[ | |||
| "sp-repo-review==2023.09.21", | |||
| "sp-repo-review==2023.10.27", | |||
There was a problem hiding this comment.
Will make a release after this.
| @@ -209,7 +211,6 @@ inspect and undo changes in git. | |||
| ```toml | |||
| [tool.ruff] | |||
| src = ["src"] | |||
| exclude = [] | |||
There was a problem hiding this comment.
Only required if you have a build folder (pypa/build, scikit-build-core), but not generally required, so dropping it here.
| @@ -239,15 +240,8 @@ extend-select = [ | |||
| ] | |||
| ignore = [ | |||
| "PLR", # Design related pylint codes | |||
| "E501", # Line too long | |||
There was a problem hiding this comment.
This is not included by default, so moving to extend-select fixes this.
| @@ -239,15 +240,8 @@ extend-select = [ | |||
| ] | |||
| ignore = [ | |||
| "PLR", # Design related pylint codes | |||
| "E501", # Line too long | |||
| "PT004", # Use underscore for non-returning fixture (use usefixture instead) | |||
There was a problem hiding this comment.
Kind of specific, and it's not the only un-ideal PT code. Let's let users add them as they need them.
| ] | ||
| typing-modules = ["mypackage._compat.typing"] | ||
| unfixable = [ | ||
| "T20", # Removes print statements |
There was a problem hiding this comment.
This is actually not a fix.
| ] | ||
| typing-modules = ["mypackage._compat.typing"] | ||
| unfixable = [ | ||
| "T20", # Removes print statements | ||
| "F841", # Removes unused variables |
There was a problem hiding this comment.
This is now an "unsafe-fix", so it's not required to list it.
| "T20", # Removes print statements | ||
| "F841", # Removes unused variables | ||
| ] | ||
| flake8-unused-arguments.ignore-variadic-names = true |
There was a problem hiding this comment.
I think this is too specific, not always needed or can be correctly avoided.
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/fix/simplenext
branch
from
1623c57 to
e454368
Compare
Simplified the Ruff config.
Will release after this.