Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use faster mechanism for type checks against DOM nodes #403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use faster mechanism for type checks against DOM nodes #403

wants to merge 1 commit into from

Conversation

mkustermann
Copy link
Contributor

@mkustermann mkustermann commented Mar 19, 2025 •
edited
Loading

The

  • <node>.isA<HTMLInputElement>() and
  • <node>.instanceOfString('HTMLInputElement')

APIs are currently performing poorly, see [0].

Instead we use <node>.instanceof(<constructor>) with a cached value of the looked up constructor.
=> This results in 5-10x faster type checks in dart2wasm.

[0] dart-lang/sdk#60344

@mkustermann
Use faster mechanism for type checks against DOM nodes
9a16bbf 
The

  * `<node>.isA<HTMLInputElement>()` and
  * `<node>.instanceOfString('HTMLInputElement')`

APIs are currently performing poorly, see [0].

Instead we use `<node>.instanceof(<constructor>)` with a cached value of
the looked up constructor. This results in 5-10x faster type checks in
dart2wasm.

[0] dart-lang/sdk#60344
@mkustermann mkustermann requested a review from schultek as a code owner March 19, 2025 12:27
@docs-page docs.page
Copy link

docs-page bot commented Mar 19, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/schultek/jaspr~403

Documentation is deployed and generated using docs.page.

@github-actions GitHub Actions
Copy link

Package Version Report

The following packages have been updated:
jaspr : 0.18.0 -> 0.18.1
jaspr_builder : 0.18.0 -> 0.18.1
jaspr_cli : 0.18.0 -> 0.18.1
jaspr_test : 0.18.0 -> 0.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schultek schultek Awaiting requested review from schultek schultek is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkustermann