Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some performance optimizations in the jaspr framework #399

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Some performance optimizations in the jaspr framework #399

merged 1 commit into from
Mar 16, 2025

Conversation

mkustermann
Copy link
Contributor

  • Avoid repeatedly accessing the same target.type JS interop field
  • Avoid unnecessary map allocation in map literal
  • Avoid unnecessary closure allocation in joining maps/strings
  • Avoid unnecessary map allocations in joining maps and one is empty

@mkustermann
Some performance optimizations in the jaspr framework
a6e0ae6 
* Avoid repeatedly accessing the same `target.type` JS interop field
* Avoid unnecessary map allocation in map literal
* Avoid unnecessary closure allocation in joining maps/strings
* Avoid unnecessary map allocations in joining maps and one is empty
@mkustermann mkustermann requested a review from schultek as a code owner March 14, 2025 14:12
@docs-page docs.page
Copy link

docs-page bot commented Mar 14, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/schultek/jaspr~399

Documentation is deployed and generated using docs.page.

@github-actions GitHub Actions
Copy link

Package Version Report

The following packages have been updated:
jaspr : 0.18.0 -> 0.18.1
jaspr_builder : 0.18.0 -> 0.18.1
jaspr_cli : 0.18.0 -> 0.18.1
jaspr_test : 0.18.0 -> 0.18.1

schultek
schultek approved these changes Mar 16, 2025
View reviewed changes
Copy link
Owner

@schultek schultek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks a lot, great stuff.

@schultek schultek merged commit 09fd5f7 into schultek:main Mar 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schultek schultek schultek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkustermann @schultek