Add --extra-js-compiler-option/--extra-wasm-compiler-option #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows jaspr users to pass any arguments to the * `dart compile js` * `dart compile wasm` compilers. For example if one wants an `-O4` optimized build but symbols for profiling one may run * `jaspr build -O4 --extra-js-compiler-option=--no-minify` * `jaspr build -O4 --experimental-wasm --extra-wasm-compiler-option=--no-strip-wasm`
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Package Version ReportThe following packages have been updated: |
mkustermann
added a commit
to mkustermann/Speedometer
that referenced
this pull request
Mar 7, 2025
This is a Jaspr Dart Web application compiled with dart2js and
dart2wasm.
The soruce is from [0] and was compiled with a modified Jaspr CLI tool
(see PR in [1]) using the following commands:
```
% rm -rf build
% dart run --resident <jaspr>/packages/jaspr_cli/bin/jaspr.dart build -O4 --extra-js-compiler-option=--no-minify
```
```
% rm -rf build
% dart run --resident <jaspr>/packages/jaspr_cli/bin/jaspr.dart build -O4 --extra-wasm-compiler-option=--no-strip-wasm --experimental-wasm
```
The relevant files in `build/jaspr/*` were copied to the JetStream
benchmark folders.
Used Dart SDK version is: 3.8.0-edge.4c8aedcb57fe678e6d30acfdc021aa9888576638
Before landing we should figure out:
* do we want both dart2js and dart2wasm?
* do we want -O2 or -O4?
* can we rely on `js-string` builtin to be evailable or not?
[0] https://github.com/mkustermann/todomvc
[1] schultek/jaspr#397
mkustermann
added a commit
to mkustermann/Speedometer
that referenced
this pull request
Mar 7, 2025
This is a Jaspr Dart Web application compiled with dart2js and
dart2wasm.
The source is from [0] and was compiled with a modified Jaspr CLI tool
(see PR in [1]) using the following commands:
```
% rm -rf build
% dart run --resident <jaspr>/packages/jaspr_cli/bin/jaspr.dart build -O4 --extra-js-compiler-option=--no-minify
```
```
% rm -rf build
% dart run --resident <jaspr>/packages/jaspr_cli/bin/jaspr.dart build -O4 --extra-wasm-compiler-option=--no-strip-wasm --experimental-wasm
```
The relevant files in `build/jaspr/*` were copied to the Speedometer
benchmark folders.
Used Dart SDK version is: 3.8.0-edge.4c8aedcb57fe678e6d30acfdc021aa9888576638
Before landing we should figure out:
* do we want both dart2js and dart2wasm?
* do we want -O2 or -O4?
* can we rely on `js-string` builtin to be evailable or not?
[0] https://github.com/mkustermann/todomvc
[1] schultek/jaspr#397
|
Thanks for the quick merge, @schultek 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows jaspr users to pass any arguments to the
dart compile jsdart compile wasmcompilers.For example if one wants an
-O4optimized build but symbols for profiling one may runjaspr build -O4 --extra-js-compiler-option=--no-minifyjaspr build -O4 --experimental-wasm --extra-wasm-compiler-option=--no-strip-wasm✨ New feature or improvement