Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render adapters #174

Merged
merged 6 commits into from
Feb 17, 2024
Merged

feat: render adapters #174

merged 6 commits into from
Feb 17, 2024

Conversation

schultek
Copy link
Owner

Description

Type of Change

  • ❌ Breaking change
  • ✨ New feature or improvement
  • 🛠️ Bug fix
  • 🧹 Code refactor
  • 📝 Documentation
  • 🗑️ Chore

Copy link

github-actions bot commented Feb 11, 2024

Package Version Report

The following packages have been updated:
jaspr : 0.10.0 -> 0.11.0
jaspr_builder : 0.10.0 -> 0.11.0
jaspr_cli : 0.10.0 -> 0.11.0
jaspr_flutter_embed : 0.2.0 -> 0.2.1
jaspr_riverpod : 0.3.9 -> 0.3.10
jaspr_router : 0.3.1 -> 0.3.2
jaspr_test : 0.10.0 -> 0.11.0

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 112 lines in your changes are missing coverage. Please review.

Comparison is base (7b17dbe) 61.52% compared to head (426b6be) 59.90%.

❗ Current head 426b6be differs from pull request most recent head a2d6d8e. Consider uploading reports for the commit a2d6d8e to get more accurate results

Files Patch % Lines
packages/jaspr/lib/src/server/child_nodes.dart 61.53% 40 Missing ⚠️
...s/jaspr/lib/src/server/document/file_document.dart 0.00% 35 Missing ⚠️
.../src/server/adapters/client_component_adapter.dart 55.00% 9 Missing ⚠️
...lib/src/server/adapters/client_script_adapter.dart 33.33% 6 Missing ⚠️
...aspr/lib/src/server/adapters/document_adapter.dart 76.00% 6 Missing ⚠️
.../src/server/adapters/element_boundary_adapter.dart 0.00% 6 Missing ⚠️
...s/jaspr/lib/src/server/document/base_document.dart 64.28% 5 Missing ⚠️
packages/jaspr/lib/src/foundation/options.dart 0.00% 3 Missing ⚠️
...ackages/jaspr/lib/src/server/render_functions.dart 0.00% 1 Missing ⚠️
packages/jaspr/lib/src/server/server_binding.dart 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   61.52%   59.90%   -1.63%     
==========================================
  Files          95      100       +5     
  Lines        4052     4180     +128     
==========================================
+ Hits         2493     2504      +11     
- Misses       1559     1676     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schultek schultek marked this pull request as ready for review February 17, 2024 12:59
@schultek schultek merged commit 5020b9d into main Feb 17, 2024
4 of 6 checks passed
@schultek schultek deleted the feat/render_adapters branch February 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant