Fixed test_bibtex unit test, updated CONTRIBUTING.md #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395.
Description
the test_bibtex function in the test module was attempting to read a file that did not exist. I updated it to read the real file name, reran the test, and it worked.
I also updated CONTRIBUTING.md to address some pitfalls that I ran into when I tried to submit my first pull request yesterday. Hopefully this will prevent other newcomers from making the same mistakes I did!
Checklist
develop
and notmain
.If you don't have a premium proxy, some of the tests will be skipped.
The tests that are run should pass without raising
MaxTriesExceededException
or other exceptions.