[DSET-4037] [DSET-4014] [DSET-4034] [DSET-4034] [DSET-4098] Dataset log exporter improvements #3
Conversation
This prefix is nor desired nor wanted.
severity to DataSet severity. Also remove "severity.text" and "severity.number" field from the event since it's redundant - we already have event severity (sev) field value.
information which is not already available (events which are sampled will already be ingested and visible in the ui so flags.is_sampled is redundant).
tomaz-s1
changed the title
tomaz-s1
changed the title
tomaz-s1
changed the title
and update affected code and tests.
|
@zdaratom I pushed some commits which I believe should address all the feedback we agreed on (I didn't push map change yet + possible parameterized tests change since I had a bit different opinion on those and we didn't agree on the approach yet). As I said before, I still plan to push one other changes in the near future (better / correct attribute name and value handling - aka getting rid non DataSet ideomatic approach of parameter.name and parameter.value). |
|
As discussed on Slack, I will work on that additional change (correct attribute field name and value handling in a separate PR in the very near future. This way I can try and submit this PR upstream for review today and get CLA, etc. sorted out as soon as possible. |
tomaz-s1
force-pushed
the
dataset_log_exporter_improvements
branch
from
2758a0a to
21c07be
Compare
There was a problem hiding this comment.
Please provide also changelog, see example https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/23640/files#diff-09e45fe4784007dc8f80bb8585acec6638363b8b72bed0cca6d24876cb1e9a6c
functions. Also move functionality for making a test record into a utility function.
|
Please provide also changelog, see example https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/23640/files#diff-09e45fe4784007dc8f80bb8585acec6638363b8b72bed0cca6d24876cb1e9a6c without that PR to public repo wont be accepted |
|
@zdaratom Thanks. Yeah, I wanted to add changelog entry, but I saw it needs to reference github issue / pr and that won't be available until I open upstream PR. So I plan to do that once upstream PR is opened. |
|
I have referenced previously created issue [20660] so far it was enough |
tomaz-s1
force-pushed
the
dataset_log_exporter_improvements
branch
from
138c36e to
401041d
Compare
This pull request contains various small improvements, changes and fixes for the DataSet Log exporter.
I bundled all the changes together since they are all on the small side and part of the general exporter clean up and improvements work.
1. Remove
OtelExporter - Log -prefix from all the DataSet eventmessagefields - DSET-4014This prefix is not needed nor desired.
2. Correctly handle log record severity / log level - DSET-4037
I updated the code to correctly handle and map from OTel LogRecord severity to DataSet event severity (logic is described in the code comments).
I also removed now redundant and unnecessary event
severity.numberandseverity.textattributes from the event.3. Remove redundant flags and flags.is_sampled attribute - DSET-4034
Remove unnecessary and redundant
flagsandflags.is_sampledattribute.4. Update metadata file to include
distributionsfield - DSET-4098Title is self explanatory.