Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TS SDK 1.0 #23

Merged
merged 9 commits into from
Jul 9, 2024
Merged

Upgrade to TS SDK 1.0 #23

merged 9 commits into from
Jul 9, 2024

Conversation

hayes-mysten
Copy link
Contributor

No description provided.

@hayes-mysten
Copy link
Contributor Author

A lot of the magic argument conversion stuff that was being done here was very relient on passing untyped values to tx.pure which has been removed. I've done my best update things to work reasonably with the new APIs, but getting exactly the same functionality probably won't work.

Hopefully this is a good enough start to get something released on the new SDK version soon

@zengxinhai
Copy link
Member

A lot of the magic argument conversion stuff that was being done here was very relient on passing untyped values to tx.pure which has been removed. I've done my best update things to work reasonably with the new APIs, but getting exactly the same functionality probably won't work.

Hopefully this is a good enough start to get something released on the new SDK version soon

Yup, we really appreciate your help on this, we'll check the code and make sure everything works fine before merge the pull request.

Copy link
Member

@fum-is-chum fum-is-chum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fum-is-chum fum-is-chum merged commit 639d3ba into scallop-io:main Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants