fix(Button): remove illegal div wrapping children #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthprost
requested review from
johnrazeur,
a team and
lisalupi
as code owners
🦋 Changeset detectedLatest commit: c9ada54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lisalupi
approved these changes
Jan 23, 2025
johnrazeur
approved these changes
Jan 24, 2025
matthprost
force-pushed
the
fix/button-alignement
branch
from
e6d79d7 to
c9ada54
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4695 +/- ##
==========================================
- Coverage 88.98% 88.98% -0.01%
==========================================
Files 227 227
Lines 7973 7970 -3
Branches 3621 3618 -3
==========================================
- Hits 7095 7092 -3
Misses 878 878
Continue to review full report in Codecov by Sentry.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Inside the button we are wrapping the text into a div for some reason. This can cause alignement issues and it is illegal according to HTML5 specifications. 🚓
Relevant logs and/or screenshots