Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): add dots in background for better visual #4650

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Documentation

Summarise concisely:

What is expected?

I added a real background on storybook stories. This seems only cool but it actually has a purpose: indicated whenever we have a background or not on our components. Our theme being full white in background we can never differentiate if we see the background of storybook or of the component.

Relevant logs and/or screenshots

Page Before After
url Screenshot 2025-01-08 at 18 01 31 Screenshot 2025-01-08 at 18 12 02
url Screenshot 2025-01-08 at 18 12 34 Screenshot 2025-01-08 at 18 12 38

@matthprost matthprost added the documentation Improvements or additions to documentation label Jan 8, 2025
@matthprost matthprost requested a review from a team January 8, 2025 17:13
@matthprost matthprost self-assigned this Jan 8, 2025
@matthprost matthprost requested review from BABAK0T0 and Lawndlwd and removed request for a team January 8, 2025 17:13
@matthprost matthprost requested a review from lisalupi as a code owner January 8, 2025 17:13
Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: 8210f58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matthprost matthprost merged commit fb00a2d into main Jan 9, 2025
11 of 12 checks passed
@matthprost matthprost deleted the docs/improve-story-visibility branch January 9, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants