refactor(menu): improve stories snippet parsing #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #1942 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 122 122
Lines 3043 3043
Branches 427 427
=======================================
Hits 2897 2897
Misses 111 111
Partials 35 35
Continue to review full report at Codecov.
|
baptisteArno
force-pushed
the
refactor/improve-menu-stories
branch
from
2dc84a6 to
e9a46fd
Compare
matthprost
approved these changes
Oct 12, 2022
matthprost
reviewed
Oct 12, 2022
@matthprost yes, I better understand how story parsing is done. Now we never have to write custom snippet. If you give your The The More info: https://storybook.js.org/docs/react/writing-docs/doc-block-source |
QuiiBz
approved these changes
Oct 13, 2022
scaleway-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
## [0.199.3](v0.199.2...v0.199.3) (2022-10-17) ### ⚡ Refactor * **expandable:** remove box ([#1945](#1945)) ([2011cec](2011cec)) * **menu:** improve stories snippet parsing ([#1942](#1942)) ([3605862](3605862)) ### 📦 Chore * **devdeps:** update actions/cache action to v3.0.11 ([#1957](#1957)) ([7902165](7902165)) * **devdeps:** update actions/setup-node action to v3.5.1 ([#1958](#1958)) ([8361139](8361139)) * **devdeps:** update dependency @scaleway/eslint-config-react to v3.7.6 ([#1955](#1955)) ([3b5c2b0](3b5c2b0)) * **devdeps:** update dependency next-transpile-modules to v9.1.0 ([#1952](#1952)) ([823b613](823b613)) * **devdeps:** update docker/build-push-action action to v3.2.0 ([#1953](#1953)) ([f5aa0db](f5aa0db)) * **devdeps:** update docker/login-action action to v2.1.0 ([#1954](#1954)) ([5eef0e2](5eef0e2)) ### 📝 Documentation * fix description not display in storybook ([#1960](#1960)) ([5ba8a87](5ba8a87)) ### 🐛 Bug Fixes * **verification-code:** add classname ([#1963](#1963)) ([4495ba6](4495ba6))
|
🎉 This PR is included in version 0.199.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No need to parse custom code snippets anymore.
Type