Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add support for multi positional args #979

Merged
merged 9 commits into from
May 4, 2020
Merged

feat(core): add support for multi positional args #979

merged 9 commits into from
May 4, 2020

Conversation

jerome-quere
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Sh4d1
Sh4d1 approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere
Copy link
Contributor Author

Need to find how to handle json response when there are multiple positional args

Sh4d1
Sh4d1 suggested changes May 3, 2020
View reviewed changes
internal/core/cobra_utils.go Outdated Show resolved Hide resolved
Sh4d1
Sh4d1 previously approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sh4d1
Sh4d1 approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere merged commit 655d012 into scaleway:v2 May 4, 2020
@jerome-quere jerome-quere deleted the multi-positional branch May 4, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sh4d1 Sh4d1 Sh4d1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerome-quere @Sh4d1