Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): add console command #897

Merged
merged 11 commits into from
May 1, 2020
Merged

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Apr 22, 2020

No description provided.

@remyleone remyleone added the instance Instance issues, bugs and feature requests label Apr 25, 2020
Sh4d1 and others added 7 commits April 30, 2020 22:31
Signed-off-by: Patrik Cyvoct <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
internal/gotty/client.go Show resolved Hide resolved
internal/gotty/client.go Outdated Show resolved Hide resolved
cnsChan, cnsErrChan := consoleReader(cns)

// Force first resize
resizeChan <- syscall.SIGWINCH
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, need to be in another file

Copy link
Contributor Author

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere merged commit 14097df into scaleway:v2 May 1, 2020
@remyleone remyleone linked an issue May 3, 2020 that may be closed by this pull request
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
* add schedule backup

* Disable update when IsBackupScheduleDisabled is false in create
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement scw server attach
3 participants