Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): remove oldbinpacking from autoscaler estimator #887

Merged
merged 1 commit into from
Apr 21, 2020
Merged

fix(k8s): remove oldbinpacking from autoscaler estimator #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-k8s-cluster-create-usage.stderr.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ ARGS:
[pools.{index}.tags.{index}] The tags associated with the pool
[autoscaler-config.scale-down-disabled] Disable the cluster autoscaler
[autoscaler-config.scale-down-delay-after-add] How long after scale up that scale down evaluation resumes
[autoscaler-config.estimator] Type of resource estimator to be used in scale up (unknown_estimator | binpacking | oldbinpacking)
[autoscaler-config.estimator] Type of resource estimator to be used in scale up (unknown_estimator | binpacking)
[autoscaler-config.expander] Type of node group expander to be used in scale up (unknown_expander | random | most_pods | least_waste | priority)
[autoscaler-config.ignore-daemonsets-utilization] Ignore DaemonSet pods when calculating resource utilization for scaling down
[autoscaler-config.balance-similar-node-groups] Detect similar node groups and balance the number of nodes between them
Expand Down
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-k8s-cluster-update-usage.stderr.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ ARGS:
[tags.{index}] The new tags associated with the cluster
[autoscaler-config.scale-down-disabled] Disable the cluster autoscaler
[autoscaler-config.scale-down-delay-after-add] How long after scale up that scale down evaluation resumes
[autoscaler-config.estimator] Type of resource estimator to be used in scale up (unknown_estimator | binpacking | oldbinpacking)
[autoscaler-config.estimator] Type of resource estimator to be used in scale up (unknown_estimator | binpacking)
[autoscaler-config.expander] Type of node group expander to be used in scale up (unknown_expander | random | most_pods | least_waste | priority)
[autoscaler-config.ignore-daemonsets-utilization] Ignore DaemonSet pods when calculating resource utilization for scaling down
[autoscaler-config.balance-similar-node-groups] Detect similar node groups and balance the number of nodes between them
Expand Down
4 changes: 2 additions & 2 deletions internal/namespaces/k8s/v1/k8s_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ func k8sClusterCreate() *core.Command {
Short: `Type of resource estimator to be used in scale up`,
Required: false,
Positional: false,
EnumValues: []string{"unknown_estimator", "binpacking", "oldbinpacking"},
EnumValues: []string{"unknown_estimator", "binpacking"},
},
{
Name: "autoscaler-config.expander",
Expand Down Expand Up @@ -510,7 +510,7 @@ func k8sClusterUpdate() *core.Command {
Short: `Type of resource estimator to be used in scale up`,
Required: false,
Positional: false,
EnumValues: []string{"unknown_estimator", "binpacking", "oldbinpacking"},
EnumValues: []string{"unknown_estimator", "binpacking"},
},
{
Name: "autoscaler-config.expander",
Expand Down