-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): implement struct required validation #751
Conversation
028f084
to
ee7f556
Compare
Signed-off-by: Patrik Cyvoct <[email protected]>
ee7f556
to
48a0e59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that we need to do that. A nested argument should not be required as it would be very painful to use.
Co-Authored-By: Quentin Brosse <[email protected]>
@QuentinBrosse k8s have required nested attributes 😄 |
Co-Authored-By: Quentin Brosse <[email protected]>
Can you give examples of commands please? |
@QuentinBrosse |
Signed-off-by: Patrik Cyvoct <[email protected]>
6debbd7
to
feaea06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR allows to fix an issue when a required argument were in a nested structure
Signed-off-by: Patrik Cyvoct [email protected]