Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implement struct required validation #751

Merged
merged 4 commits into from
Mar 13, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Mar 9, 2020

This PR allows to fix an issue when a required argument were in a nested structure

Signed-off-by: Patrik Cyvoct [email protected]

@Sh4d1 Sh4d1 force-pushed the fix_required_struct branch from 028f084 to ee7f556 Compare March 9, 2020 15:08
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that we need to do that. A nested argument should not be required as it would be very painful to use.

internal/core/validate.go Outdated Show resolved Hide resolved
internal/core/validate.go Show resolved Hide resolved
@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Mar 11, 2020

@QuentinBrosse k8s have required nested attributes 😄

@QuentinBrosse
Copy link
Contributor

@QuentinBrosse k8s have required nested attributes 😄

Can you give examples of commands please?

@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Mar 11, 2020

@QuentinBrosse scw k8s cluster create need some default-pool-config.xxx fields

Signed-off-by: Patrik Cyvoct <[email protected]>
@Sh4d1 Sh4d1 force-pushed the fix_required_struct branch from 6debbd7 to feaea06 Compare March 11, 2020 14:21
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 6dae643 into scaleway:v2 Mar 13, 2020
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants