Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(as): add server type list format #1748

Merged
merged 2 commits into from
Feb 8, 2021
Merged

feat(as): add server type list format #1748

merged 2 commits into from
Feb 8, 2021

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

jerome-quere
jerome-quere suggested changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this type of use case, you should rely on human marshaling override. Overriding the response type in an interceptor makes you loose data in the JSON output

@remyleone remyleone merged commit 168d2e6 into scaleway:master Feb 8, 2021
@remyleone remyleone deleted the server_type_list branch February 8, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remyleone @jerome-quere