feat(core): handle map in request arguments #1569

Sh4d1 · 2020-11-26T16:35:58Z

Signed-off-by: Patrik Cyvoct [email protected]

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Handle maps in arguments

Signed-off-by: Patrik Cyvoct <[email protected]>

internal/args/unmarshal.go

Signed-off-by: Patrik Cyvoct <[email protected]>

internal/core/arg_specs.go

Signed-off-by: Patrik Cyvoct <[email protected]>

Sh4d1 added 2 commits November 26, 2020 17:35

feat(core): handle map in request arguments

ccd6763

Signed-off-by: Patrik Cyvoct <[email protected]>

fix tests

d576d13

Signed-off-by: Patrik Cyvoct <[email protected]>

jerome-quere reviewed Nov 26, 2020

View reviewed changes

internal/args/unmarshal.go Show resolved Hide resolved

jerome-quere suggested changes Nov 26, 2020

View reviewed changes

internal/args/unmarshal.go Outdated Show resolved Hide resolved

fix review

12e0f4f

Signed-off-by: Patrik Cyvoct <[email protected]>

jerome-quere reviewed Nov 27, 2020

View reviewed changes

internal/core/arg_specs.go Outdated Show resolved Hide resolved

fix

e80c475

Signed-off-by: Patrik Cyvoct <[email protected]>

jerome-quere approved these changes Nov 27, 2020

View reviewed changes

jerome-quere merged commit f2614ad into scaleway:master Nov 27, 2020

Provide feedback